Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a file structure sidebar in the editor #1943

Merged
merged 14 commits into from
Sep 7, 2024

Conversation

CF3B5
Copy link
Contributor

@CF3B5 CF3B5 commented Jul 14, 2024

Description

The configuration file is too long, so I did this feature, clicking on the structure tree item will jump to the number of file lines.

Related Tickets & Documents

none.

Mobile & Desktop Screenshots/Recordings

Voron-2-4
the sidebar is hidden on mobile screen.

[optional] Are there any post-deployment tasks we need to perform?

none.

Signed-off-by: cf3b5 cf3b5bb@gmail.com

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 14, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 2 0
zh.json 13 1

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@meteyou
Copy link
Member

meteyou commented Jul 14, 2024

thanks for the PR! i'm looking forward to testing it. if you need any help or information from me about the prettier test, feel free to ping me!

@meteyou meteyou self-requested a review July 14, 2024 15:24
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@CF3B5
Copy link
Contributor Author

CF3B5 commented Jul 14, 2024

thanks for the PR! i'm looking forward to testing it. if you need any help or information from me about the prettier test, feel free to ping me!

I try my best. Why do I always fail the prettier test. :-(

@meteyou
Copy link
Member

meteyou commented Jul 14, 2024

@CF3B5 just try to run npm run format and commit & push the changes...

@meteyou
Copy link
Member

meteyou commented Jul 14, 2024

This PR should also fix #1320

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@meteyou
Copy link
Member

meteyou commented Jul 17, 2024

Many thanks for this PR! I really love this function!

I just have one small suggestion for improvement. Would it be possible to jump to the section when clicking on the name and only open/close the attributes when clicking on the triangle?

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@CF3B5
Copy link
Contributor Author

CF3B5 commented Jul 18, 2024

Many thanks for this PR! I really love this function!

I just have one small suggestion for improvement. Would it be possible to jump to the section when clicking on the name and only open/close the attributes when clicking on the triangle?

ok, I've changed. thank you for liking this feature :-)

src/components/TheEditor.vue Outdated Show resolved Hide resolved
src/components/TheEditor.vue Outdated Show resolved Hide resolved
src/components/TheEditor.vue Outdated Show resolved Hide resolved
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1

@meteyou meteyou added this to the v2.13.0 milestone Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2024
@meteyou meteyou changed the title feat: CodeMirror dialog box adds a file structure sidebar feat: adds a file structure sidebar in the editor Sep 7, 2024
@meteyou meteyou merged commit 695832a into mainsail-crew:develop Sep 7, 2024
11 checks passed
@meteyou
Copy link
Member

meteyou commented Sep 7, 2024

@CF3B5 thanks for your PR!

i just fixed some visual issues in the treeview and refactored some code blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants