-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(History): add option to show stats in different values #2007
feat(History): add option to show stats in different values #2007
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request adds a new feature to the history page, allowing users to switch between different statistical views (amount, filament, time) for both the circle chart and table display. The implementation involves refactoring existing components, introducing a new mixin for shared logic, and updating the UI to include toggle buttons for the new options. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meteyou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@sourcery-ai review |
Language file analysis report:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meteyou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meteyou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Language file analysis report:
|
@meteyou there still two pending comments. I would at least adjust the rounding before merging. |
…ableItem Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Description
This PR adds an option to switch the stats (circle or table) in the history page between amount, filament and time.
Related Tickets & Documents
fixes #1966
Mobile & Desktop Screenshots/Recordings
Circle Amount:
Circle Filament:
Circle Time:
Table Amount:
Table Filament:
Table Time:
[optional] Are there any post-deployment tasks we need to perform?
none
Summary by Sourcery
Introduce a feature to toggle the display of history statistics between different units (amount, filament, time) and refactor the code to improve maintainability by using a mixin for history statistics logic.
New Features:
Enhancements: