Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bid parsing for V1 #110

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fixed bid parsing for V1 #110

merged 2 commits into from
Aug 6, 2024

Conversation

ZhmakAS
Copy link
Collaborator

@ZhmakAS ZhmakAS commented Aug 6, 2024

  • Resolves: #

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits are signed
  • Tests included/updated or not needed
  • Documentation (manuals or wiki) has been updated or is not required

Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, check my comment. There may be a type/marshal error

"../data/bid/auction_bid_example_v1.json",
},
{
"Auction Bid V1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2?

types/bid.go Outdated
// Public Key of the delegator
Delegatee keypair.PublicKey `json:"delegatee"`
// Public key of the validator
ValidatorPublicKey keypair.PublicKey `json:"validator_public_key"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the schema please. I think the fields here are:

  • delegatee. the validator public key
  • public_key. the delegator public key.

Fixed after review
Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhmakAS ZhmakAS merged commit ec15fc0 into master Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants