-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ember v4.12 & use latest ember-power-calendar
version
#54
base: master
Are you sure you want to change the base?
Conversation
* drop support for ember < 3.28 * drop node < 16 * update dependency ember-auto-import & broccoli-funnel
ember-power-calendar
version
ember-power-calendar
versionember-power-calendar
version
cc @makepanic |
@makepanic friendly ping... |
They are still slightly active on github so hopefully we don't need to resort to a fork.. |
I tried registering this plugin (from main branch) with ember-power-calendar 0.21.0, it kinda worked when I imported from the incorrect name 'ember-power-calendar-utils' but it had issues in my embroider application. I then tried the same with this PR (but importing from the correct namespace), but I had trouble forking this addon and installing this PR as an addon. So I've just copied the import { registerDateLibrary } from "ember-power-calendar";
import * as DateUtils from "my-app/utils/ember-power-calendar-date-fns/unlocalized";
registerDateLibrary(DateUtils); I'll keep an eye on this PR if the maintainer ever comes back to merge & release it but I appreciate the work you did here. Others will probably find it useful too. |
@makepanic can we get a release with this changes, otherwise we get a lot of noises on our If you don't have time to maintain, it would be good to get permissions to merge changes / deploy them. As alternative we have planned to bring this addon earlier / later directly to our core addon |
@makepanic Can you please review this PR? I'm starting to run into this as well. |
@makepanic can you please review this PR? As @mkszepp said, if you are unable to maintain at this time can you delegate maintenance to someone else? |
I think there is no other way as making a fork for that and release that... I will try to find time in next days. For now you can use my fork. When i have done i will notify here everyone |
fix #53 & fix #42
related issue