Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ember v4.12 & use latest ember-power-calendar version #54

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mkszepp
Copy link

@mkszepp mkszepp commented Sep 4, 2023

fix #53 & fix #42

  • drop support for ember < 3.28
  • drop node < 16
  • update dependency ember-auto-import & broccoli-funnel
  • update date-fns to v3
  • extend isSame (necessary beginning with v1.0.1 of ember-power-calendar)

related issue

* drop support for ember < 3.28
* drop node < 16
* update dependency ember-auto-import & broccoli-funnel
@mkszepp mkszepp changed the title Update to ember v4.12 Update to ember v4.12 & latest ember-power-calendar version Sep 4, 2023
@mkszepp mkszepp changed the title Update to ember v4.12 & latest ember-power-calendar version Update to ember v4.12 & use latest ember-power-calendar version Sep 4, 2023
@Techn1x
Copy link

Techn1x commented Sep 5, 2023

cc @makepanic

@mkszepp
Copy link
Author

mkszepp commented Nov 15, 2023

@makepanic friendly ping... ember-power-calendar is now released

@Techn1x
Copy link

Techn1x commented Nov 16, 2023

They are still slightly active on github so hopefully we don't need to resort to a fork..

@Techn1x
Copy link

Techn1x commented Dec 1, 2023

I tried registering this plugin (from main branch) with ember-power-calendar 0.21.0, it kinda worked when I imported from the incorrect name 'ember-power-calendar-utils' but it had issues in my embroider application. I then tried the same with this PR (but importing from the correct namespace), but I had trouble forking this addon and installing this PR as an addon.

So I've just copied the unlocalized.js and format-util.js files into my application (I was using with includeLocales: false, so didn't need localized.js) and then register the unlocalized file as my plugin

import { registerDateLibrary } from "ember-power-calendar";
import * as DateUtils from "my-app/utils/ember-power-calendar-date-fns/unlocalized";
registerDateLibrary(DateUtils);

I'll keep an eye on this PR if the maintainer ever comes back to merge & release it but I appreciate the work you did here. Others will probably find it useful too.

@mkszepp
Copy link
Author

mkszepp commented Apr 7, 2024

@makepanic can we get a release with this changes, otherwise we get a lot of noises on our ember-power-calendar package, that this meta packages is outdated...

If you don't have time to maintain, it would be good to get permissions to merge changes / deploy them.

As alternative we have planned to bring this addon earlier / later directly to our core addon

@veelci
Copy link
Contributor

veelci commented Apr 10, 2024

@makepanic Can you please review this PR? I'm starting to run into this as well.

@krisswiltshire30
Copy link

@makepanic can you please review this PR?

As @mkszepp said, if you are unable to maintain at this time can you delegate maintenance to someone else?

@mkszepp
Copy link
Author

mkszepp commented Jun 1, 2024

I think there is no other way as making a fork for that and release that...

I will try to find time in next days. For now you can use my fork.

When i have done i will notify here everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update addon to make compatible with latest ember-power-calendar version Embroider compatibility
4 participants