Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2497] chore: update pages' offline badge tooltip content #5652

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Sep 18, 2024

This PR updates the content for the offline badge on pages.

Plane issue: WEB-2497

Summary by CodeRabbit

  • New Features
    • Updated tooltip content for offline mode to clarify that users can continue making changes while offline, with assurance of syncing once back online.
  • Bug Fixes
    • Improved grammatical correctness in tooltip heading from "You are offline" to "You are offline."

@aaryan610 aaryan610 added this to the v0.23-dev milestone Sep 18, 2024
@aaryan610 aaryan610 changed the title [WEB-2497] chore: update offline badge tooltip content [WEB-2497] chore: update pagesoffline badge tooltip content Sep 18, 2024
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes in the PageExtraOptions component focus on updating the tooltip content that appears when a user is offline. The tooltip now emphasizes that users can continue making changes while offline, with a clear message that these changes will sync once the internet connection is restored. Additionally, a minor grammatical correction was made to the tooltip heading.

Changes

File Path Change Summary
web/core/components/pages/editor/header/extra-options.tsx Updated tooltip content for offline mode to clarify user capabilities and corrected grammatical error.

Possibly related PRs

  • [WEB-2474] chore: update page lock authorization #5635: The changes in the Page class's canCurrentUserLockPage method may relate to user permissions and functionality that could be impacted by the offline behavior described in the main PR, although they do not directly modify the same component or file.

Suggested reviewers

  • SatishGandham

🐰 In the land of code where changes bloom,
A tooltip now shines, dispelling the gloom.
"Offline, but worry not," it cheerfully states,
"Your edits will sync when the connection awaits!"
Hopping through updates, we celebrate cheer,
For clarity reigns, and the message is clear! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 84256ca and ccf7dd6.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • web/core/components/pages/editor/header/extra-options.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/core/components/pages/editor/header/extra-options.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 changed the title [WEB-2497] chore: update pagesoffline badge tooltip content [WEB-2497] chore: update pages' offline badge tooltip content Sep 18, 2024
Copy link
Collaborator

@SatishGandham SatishGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add the yarn.lock changes if they are not part of the PR.

@pushya22 pushya22 merged commit 22b32fd into preview Sep 23, 2024
14 of 15 checks passed
@pushya22 pushya22 deleted the chore/offline-content branch September 23, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants