Stephen's frontend-api-challenge #125
Conversation
| class ChitterApi { | ||
|
|
||
| loadPeeps(callback) { | ||
| const callbackFn = callback || (() => { }) |
There was a problem hiding this comment.
You reference this a lot - not sure why you have it but you could make it a line in the constructor eg. this.callbackFn() instead of writing it every time
| // const divEl = this.makeElement('#main-container', 'div', 'post-peep'); | ||
| const divEl = document.querySelector('#post-peep') | ||
|
|
||
| const peepEl = this.makeElement('#post-peep', 'input', 'post-content'); |
There was a problem hiding this comment.
really like this quick way of making an element!
| }) | ||
|
|
||
| it('displays peeps', () => { | ||
| const peepsView = new PeepsView(model); |
| model = new PeepsModel; | ||
| }) | ||
|
|
||
| it('displays peeps', () => { |
There was a problem hiding this comment.
this only tests that you display a single peep, would it not be worth testing for multiple peeps?
| } | ||
| ] | ||
|
|
||
| const api = { loadPeeps: (callback) => callback(peep) }; |
There was a problem hiding this comment.
since this is a mocked function you could test that this is being called at all
| }) | ||
|
|
||
| it('posts a peep', () => { | ||
| const peeps = [ |
There was a problem hiding this comment.
this could be saved as a variable accessible by multiple tests instead of repeating the same code
| @@ -0,0 +1,143 @@ | |||
| class PeepsView { | |||
| constructor(model, api) { | |||
| this.user_id = ""; | |||
There was a problem hiding this comment.
I saved this data to model rather than view as model is for saving data and view is for displaying it, not sure if that's correct though
| } | ||
|
|
||
| makeElement(parent, type, id) { | ||
| const El = document.createElement(type); |
There was a problem hiding this comment.
variables need to be lower case first letter
My effort at test driving a JavaScript single page frontend app interfacing with the makers API to:
It's rough around the edges but all code is test driven.