Chitter frontend #126
Chitter frontend #126
Conversation
| testPeepsArray = require("./testPeepsArray"); | ||
| testUserSessionResponse = require("./testUserSessionResponse"); | ||
| testPostPeepResponse = require("./testPostPeepResponse"); | ||
| testDeletePeepResponse = require("./testDeletePeepResponse"); | ||
| fetch.resetMocks(); |
There was a problem hiding this comment.
Overall the tests are logical and beautifully written. Main question is:
Would the tests have achieved the same objectives with 'simple' data rather than the 'real' examples you've used in each of the files?
You could have all of your test data in one json file (test-data.json for example?)
I like that you've used the example data - but if the tests have the same integrity with simplified data then it would be best to simplify.
| fetch("https://chitter-backend-api-v2.herokuapp.com/peeps", { | ||
| method: "POST", | ||
| headers: { | ||
| Authorization: `Token token=${sessionKey}`, |
There was a problem hiding this comment.
Interesting difference here.
Will also work as 'Token token=' + sessionKey
I don't know which is best.
| resetUserId() { | ||
| this.userId = null; | ||
| } |
There was a problem hiding this comment.
This method has not been tested in chitterModel.test.js
| resetSessionKey() { | ||
| this.sessionKey = null; | ||
| } |
There was a problem hiding this comment.
This method has not been tested in chitterModel.test.js
| expect(peepDivEls[0].querySelector(".peep-body").textContent).toBe( | ||
| "First peep" | ||
| ); | ||
| expect(peepDivEls[0].querySelector(".peep-user-handle").textContent).toBe( | ||
| "jony144" | ||
| ); | ||
| expect( | ||
| peepDivEls[0].querySelector(".peep-datetime-created").textContent | ||
| ).toBe("12:33 Sat Aug 20 2022"); | ||
| expect(peepDivEls[0].querySelector(".peep-likes-count").textContent).toBe( | ||
| "1 like" | ||
| ); | ||
| expect(peepDivEls[1].querySelector(".peep-body").textContent).toBe( | ||
| "i'm tiz" | ||
| ); | ||
| expect(peepDivEls[1].querySelector(".peep-user-handle").textContent).toBe( | ||
| "tiz" | ||
| ); | ||
| expect( | ||
| peepDivEls[1].querySelector(".peep-datetime-created").textContent | ||
| ).toBe("13:04 Sun Aug 07 2022"); | ||
| expect(peepDivEls[1].querySelector(".peep-likes-count").textContent).toBe( | ||
| "0 likes" |
There was a problem hiding this comment.
The test is confirming you fetched two test peeps. You could get away with testing all elements on the first peep and then just one element to confirm the second peep is there. This simplifies the test without a big compromise in integrity.
| expect(newPeepEls[0].querySelector(".peep-body").textContent).toBe( | ||
| "my first peep :)" | ||
| ); | ||
| expect(newPeepEls[0].querySelector(".peep-user-handle").textContent).toBe( | ||
| "kay" | ||
| ); | ||
| expect( | ||
| newPeepEls[0].querySelector(".peep-datetime-created").textContent | ||
| ).toBe("14:21 Sat Jun 23 2018"); | ||
| expect(newPeepEls[0].querySelector(".peep-likes-count").textContent).toBe( | ||
| "0 likes" |
There was a problem hiding this comment.
Don't need to test all elements if peep has been created
No description provided.