Next 2.0 version configuration improvements #162
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pounard
commented
May 28, 2024
pounard
commented
- Rename lots of configuration options for consistency (deprecation only, your configuration will not break).
- Fix some documentation.
- Introduce environment variables for configuration.
pounard
force-pushed
the
2.0-configuration-improvements
branch
from
55e930e
to
4cbd3fe
Compare
pounard
force-pushed
the
2.0-configuration-improvements
branch
2 times, most recently
from
b8bdfb2
to
1507fde
Compare
pounard
force-pushed
the
2.0-configuration-improvements
branch
4 times, most recently
from
4340051
to
fffe5a9
Compare
pounard
force-pushed
the
standalone
branch
16 times, most recently
from
0d1b966
to
beefd06
Compare
pounard
force-pushed
the
2.0-configuration-improvements
branch
from
fffe5a9
to
164d0d8
Compare
pounard
force-pushed
the
standalone
branch
2 times, most recently
from
5835a02
to
d0791ff
Compare
pounard
force-pushed
the
standalone
branch
4 times, most recently
from
079cc2a
to
0a07d89
Compare
pounard
force-pushed
the
2.0-configuration-improvements
branch
from
164d0d8
to
41c33c3
Compare
docs/content/console.md
Outdated
Comment on lines
77
to
83
| ### Dumping from Symfony configuration | ||
|
|
||
| :::warning | ||
| When using the CLI tool, you are not in the Symfony application context anymore, | ||
| which means the CLI tool doesn't know the Symfony database configuration, doctrine | ||
| connections or doctrine ORM mapping. | ||
| ::: | ||
|
|
||
| @todo |
There was a problem hiding this comment.
does this command exist now ?
There was a problem hiding this comment.
Nope I opened #156 for this, maybe I should simply remove this file until it does.
pounard
force-pushed
the
2.0-configuration-improvements
branch
7 times, most recently
from
06aa04f
to
d597917
Compare
pounard
force-pushed
the
2.0-configuration-improvements
branch
from
d597917
to
a77cb1c
Compare
pounard
commented
Nov 12, 2024
| # variables will be used per default, if defined, but will be ignored when | ||
| # you override the related parameter in the "config/packages/db_tools.yaml" | ||
| # file. | ||
| env(DBTOOLS_BACKUP_BINARY_MARIADB): ~ |
There was a problem hiding this comment.
That's a lot of repetitions, I wonder if this shouldn't be dynamic using some vendor name loop somewhere in a compiler pass?
Moreover, everything else is configured on a per-connection basis, and this is configured on a per-vendor basis, it is somehow disturbing IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.