Fix typed property must not be accessed before initialization error when using --list option #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typed property must not be accessed before initialization error when using --list option
pounard
reviewed
Nov 5, 2024
pounard
reviewed
Nov 5, 2024
pounard
reviewed
Nov 5, 2024
|
Hello @iNem0o, thanks, your PR seems fine, please fix the minor comments and it's all good. Pipeline failure seems unrelated, we'll see how it behave on your next push. If it continues to fail I'll pull your branch and test on my side to be sure it's completely unrelated. |
|
Hello @pounard, I have made the requested changes as per your feedback. |
|
@iNem0o thanks, I'll review this tomorrow. |
|
@iNem0o Thanks! I'll add a line in the changelog file. |
pounard
pushed a commit
that referenced
this pull request
Nov 6, 2024
…rror when using --list option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
When using the
db-tools:restore --listcommand, in thelistBackup()method the$this->restorervariable is not inited yet which lead to a fatal error.https://github.com/makinacorpus/DbToolsBundle/blob/main/src/Command/RestoreCommand.php#L97
As the restorer is inited lately in the main process
https://github.com/makinacorpus/DbToolsBundle/blob/main/src/Command/RestoreCommand.php#L110
i added the same call to the factory inside the
listBackups()method to fix and tests case for the --list option