Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor media storage usage #298

Merged
merged 12 commits into from
Apr 10, 2024
Merged

Refactor media storage usage #298

merged 12 commits into from
Apr 10, 2024

Conversation

submarcos
Copy link
Member

... and improve tests

mapentity/views/generic.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 85.52632% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 90.98%. Comparing base (b62a75a) to head (ca55a4c).

Files Patch % Lines
mapentity/registry.py 63.63% 4 Missing ⚠️
mapentity/helpers.py 84.21% 3 Missing ⚠️
mapentity/views/base.py 25.00% 3 Missing ⚠️
mapentity/views/generic.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   90.50%   90.98%   +0.48%     
==========================================
  Files          32       32              
  Lines        2411     2397      -14     
==========================================
- Hits         2182     2181       -1     
+ Misses        229      216      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos merged commit d2bf92c into master Apr 10, 2024
10 of 11 checks passed
@submarcos submarcos deleted the improve_test_and_storage branch April 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant