adding check for nullity in related models delete #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When related models are deleted, the block of code here around models.py:234 gives the error:
File "/workspaces/project/.venv/lib/python3.9/site-packages/safedelete/models.py", line 246, in soft_delete_cascade_policy_action
_, delete_response = res
TypeError: cannot unpack non-iterable NoneType object
Based on the context, seems like this bug comes about because the original object that is being deleted appears in the related_objects(self) function.
This issue appeared in django = "4.1.7", the latest version of django-safedelete as well as 1.3.3. Python version is Python 3.9.20. This is the exact bug in #235