Improved exit codes for reactor commands

mako-framework · Nov 15, 2024 · 67b620f · 67b620f
1 parent aee6def
commit 67b620f
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 53 deletions.
diff --git a/src/mako/reactor/CommandInterface.php b/src/mako/reactor/CommandInterface.php
@@ -22,6 +22,16 @@ interface CommandInterface
 	 */
 	public const int STATUS_ERROR = 1;
 
+	/**
+	 * Incorrect usage status code.
+	 */
+	public const int STATUS_INCORRECT_USAGE = 2;
+
+	/**
+	 * Unknown command status code.
+	 */
+	public const int STATUS_UNKNOWN_COMMAND = 127;
+
 	/**
 	 * Returns the command.
 	 *

diff --git a/src/mako/reactor/Reactor.php b/src/mako/reactor/Reactor.php
@@ -289,7 +289,7 @@ protected function unknownCommand(string $command): int
 
 		$this->listCommands();
 
-		return CommandInterface::STATUS_ERROR;
+		return CommandInterface::STATUS_UNKNOWN_COMMAND;
 	}
 
 	/**
@@ -375,7 +375,7 @@ public function run(): int
 		catch (ArgumentException|UnexpectedValueException $e) {
 			$this->output->errorLn("<red>{$e->getMessage()}</red>");
 
-			return CommandInterface::STATUS_ERROR;
+			return CommandInterface::STATUS_INCORRECT_USAGE;
 		}
 	}
 }