Fix PopulateDebugCommandPass to avoid getting services from container…

… on compile time
maks-rafalko · Jul 6, 2018 · 1a5de36 · 1a5de36
1 parent 5f0b448
commit 1a5de36
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 28 deletions.
diff --git a/src/Command/DebugCommand.php b/src/Command/DebugCommand.php
@@ -2,10 +2,13 @@
 
 namespace BornFree\TacticianDomainEventBundle\Command;
 
+use BornFree\TacticianDomainEvent\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
+use Symfony\Component\DependencyInjection\Container;
+use Symfony\Component\DependencyInjection\ContainerInterface;
 
 class DebugCommand extends Command
 {
@@ -14,11 +17,36 @@ class DebugCommand extends Command
      */
     private $mappings;
 
-    public function __construct(array $mappings)
+    public function __construct(ContainerInterface $container, array $listeners, array $subscribers)
     {
         parent::__construct();
 
-        $this->mappings = $mappings;
+        $events = [];
+
+        foreach ($listeners as $serviceId => $tags) {
+            foreach ($tags as $tag) {
+                $listener = $container->get($serviceId);
+                $method = array_key_exists('method', $tag) ? $tag['method'] : '__invoke';
+
+                $events[$tag['event']][] = get_class($listener) . '::' . $method;
+            }
+        }
+
+        foreach ($subscribers as $serviceId => $tags) {
+            $subscriber = $container->get($serviceId);
+
+            if (!$subscriber instanceof EventSubscriberInterface) {
+                continue;
+            }
+
+            foreach ($subscriber->getSubscribedEvents() as $event => $method) {
+                $events[$event][] = get_class($subscriber) . '::' . $method[1];
+            }
+        }
+
+        ksort($events);
+
+        $this->mappings = $events;
     }
 
     protected function configure()

diff --git a/src/DependencyInjection/Compiler/PopulateDebugCommandPass.php b/src/DependencyInjection/Compiler/PopulateDebugCommandPass.php
@@ -18,30 +18,7 @@ public function process(ContainerBuilder $container)
         $subscribers = $container->findTaggedServiceIds('tactician.event_subscriber');
         $listeners = $container->findTaggedServiceIds('tactician.event_listener');
 
-        $events = [];
-
-        foreach ($listeners as $serviceId => $tags) {
-            foreach ($tags as $tag) {
-                $listener = $container->getDefinition($serviceId);
-                $method = array_key_exists('method', $tag) ? $tag['method'] : '__invoke';
-
-                $events[$tag['event']][] = $listener->getClass() . '::' . $method;
-            }
-        }
-
-        foreach ($subscribers as $serviceId => $tags) {
-            $subscriber = $container->get($serviceId);
-
-            if (!$subscriber instanceof EventSubscriberInterface) {
-                continue;
-            }
-
-            foreach ($subscriber->getSubscribedEvents() as $event => $method) {
-                $events[$event][] = get_class($subscriber) . '::' . $method[1];
-            }
-        }
-
-        ksort($events);
-        $command->setArgument(0, $events);
+        $command->setArgument(1, $listeners);
+        $command->setArgument(2, $subscribers);
     }
 }
diff --git a/src/Resources/config/services.yml b/src/Resources/config/services.yml
@@ -2,13 +2,15 @@ services:
     tactician_domain_events.dispatcher:
         class: BornFree\TacticianDomainEvent\EventDispatcher\EventDispatcher
         lazy: true
-        
+
     tactician_domain_events.middleware.release_recorded_events:
         class: BornFree\TacticianDomainEvent\Middleware\ReleaseRecordedEventsMiddleware
         arguments: ['@tactician_domain_events.doctrine.event_collector', '@tactician_domain_events.dispatcher']
         lazy: true
 
     tactician_domain_events.command.debug:
         class: BornFree\TacticianDomainEventBundle\Command\DebugCommand
+        arguments:
+            - '@service_container'
         tags:
             - { name: console.command }