Skip to content

Fix bug with ttc args #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkickling merged 4 commits into from
Dec 2, 2025
Merged

Fix bug with ttc args #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bb761f
Make requirements work with mal-sim
sandorstormen Dec 2, 2025
753d890
Fix: bug
sandorstormen Dec 2, 2025
cc1b39a
Update .gitignore to include uv.lock and logs directory
sandorstormen Dec 2, 2025
0ebbc7f
Enhance defense argument check in MainWindow to ensure ttc has valid …
sandorstormen Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,8 @@ myvenv/
vscode/

#Mac Specific
.DS_Store
.DS_Store

uv.lock

logs/**
4 changes: 2 additions & 2 deletions mal_gui/main_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def update_properties_window(self, asset_item: AssetItem):
for attack_step_name, value in asset.defenses.items():
# Add defenses that are set in model
attack_step = asset.lg_asset.attack_steps[attack_step_name]
if attack_step.ttc:
if attack_step.ttc and len(attack_step.ttc['arguments']) > 0:
default_value = attack_step.ttc['arguments'][0]
else:
default_value = 0.0
Expand All @@ -309,7 +309,7 @@ def update_properties_window(self, asset_item: AssetItem):
if attack_step.name in asset.defenses:
continue
if attack_step.type == "defense":
if attack_step.ttc:
if attack_step.ttc and len(attack_step.ttc['arguments']) > 0:
default_value = attack_step.ttc['arguments'][0]
else:
default_value = 0.0
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ authors = [
{name="Sandor Berglund", email="sandorb@kth.se"},
]
readme = "README.md"
requires-python = ">=3.8,<=3.13"
requires-python = ">=3.10,<=3.13"
dependencies = [
"networkx==3.2.1",
"numpy==1.26.4",
Expand Down