-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Keep same path to language as in Scenario #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ne YAML integration
|
Yes, it's a bit dirty. And it will break if you save it to a different location than you loaded it for, no? |
Yes, but if I manually set a path in the file, I except it to be preserved. It will not break if you create the scenario from the mal-gui. |
|
This is better than it is now. With the current mal-gui I have to change the lang path every time I switch computer. |
|
Sure, but if you load a scenario in the mal gui and then save it to a different location it will break. Currently it might not be the most common usecase, but also not super weird thing to do? I see the annoyance, but is it worth it to merge this fix in your opinion instead of finding a solution that works also doesn't break the use case |
That's up to you to decide. I'm going to be using this branch because it fixes my problem. Also, is it every convenient to have an absolute path to the lang file? The current standard operating procedure seems to be that you save the language in the repo. For the |
Dirty fix to preserve lang paths from scenario and not make them absolute.