Skip to content

Conversation

@sandorstormen
Copy link
Contributor

@sandorstormen sandorstormen commented Dec 18, 2025

Dirty fix to preserve lang paths from scenario and not make them absolute.

@sandorstormen sandorstormen linked an issue Dec 18, 2025 that may be closed by this pull request
@mrkickling
Copy link
Contributor

Yes, it's a bit dirty. And it will break if you save it to a different location than you loaded it for, no?

@sandorstormen
Copy link
Contributor Author

Yes, it's a bit dirty. And it will break if you save it to a different location than you loaded it for, no?

Yes, but if I manually set a path in the file, I except it to be preserved. It will not break if you create the scenario from the mal-gui.

@sandorstormen
Copy link
Contributor Author

sandorstormen commented Dec 18, 2025

This is better than it is now. With the current mal-gui I have to change the lang path every time I switch computer.

@mrkickling
Copy link
Contributor

mrkickling commented Dec 18, 2025

Sure, but if you load a scenario in the mal gui and then save it to a different location it will break. Currently it might not be the most common usecase, but also not super weird thing to do? I see the annoyance, but is it worth it to merge this fix in your opinion instead of finding a solution that works also doesn't break the use case load scenario->save in different location?

@sandorstormen
Copy link
Contributor Author

Sure, but if you load a scenario in the mal gui and then save it to a different location it will break. Currently it might not be the most common usecase, but also not super weird thing to do? I see the annoyance, but is it worth it to merge this fix in your opinion instead of finding a solution that works also doesn't break the use case load scenario->save in different location?

That's up to you to decide. I'm going to be using this branch because it fixes my problem.

Also, is it every convenient to have an absolute path to the lang file? The current standard operating procedure seems to be that you save the language in the repo. For the mal-simulator, all scenarios have relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAL GUI doesn't preserve lang file paths

3 participants