Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webassembly 2.0 support: part 1 #149

Merged
merged 75 commits into from
Sep 24, 2022
Merged

Webassembly 2.0 support: part 1 #149

merged 75 commits into from
Sep 24, 2022

Conversation

malcolmstill
Copy link
Owner

@malcolmstill malcolmstill commented Sep 4, 2022 •
edited
Loading

Description

Part 1 of adding WebAssembly 2.0 support:

  • reference types
  • table instructions
  • multiple tables
  • bulk memory / table instructions

Follow ups

  • I will add support for vector / SIMD in a second PR
  • The bulk memory / table operations are only functionally correct (using existing functions). These should be optimised to only perform a single check then perform the writes rather than a check for each write

@malcolmstill malcolmstill changed the title Copy in WebAssembly/testsuite e25ae159357c055b3a6fac99043644e208d26d2a Update Webassembly/testsuite Sep 4, 2022
@malcolmstill malcolmstill force-pushed the malcolm/testsuite-update branch from 19e87cc to e1c5bdf Compare September 4, 2022 18:41
@malcolmstill
Rename trunc_sat -> misc
fb5ad90
@malcolmstill
Rename trunc_sat -> misc, add type safety of MiscOpcode
204ee8b
@malcolmstill
Rename
ada5aa4
@malcolmstill
Validate memory.init needs data count section
a1b4d92
@malcolmstill
Validate data.drop
5bc6fcf
@malcolmstill
Initial support for new element section format
8344d85 
- The element section if backwards compatible, so take the code
  after reading the table index and put that in a case for elem
  type 0
- All other elem types not yet implemented
- Adds RefType and NumType enums and expands ValueType
@malcolmstill malcolmstill force-pushed the malcolm/testsuite-update branch from 2c24759 to 8344d85 Compare September 4, 2022 22:30
@malcolmstill
Some DataSegment stuff
6acefaa
@malcolmstill
Working memory_init.wast
cabd2ae
@malcolmstill
DataSegment type 2
961a81c
@malcolmstill
New memory tests
0b14f10
@malcolmstill
Better variable naming
c8adc49
@malcolmstill
index -> funcidx
b688605
@malcolmstill
ref tests
3e14117 
- Add references list to module
- funcidx* are added to references from globals, elements, exports
- REF_NULL chosen (at the moment) as 0xFFFFFFFFFFFFFFFF
@malcolmstill
table.init work
9e9904d
@malcolmstill
Add table.copy
8b147ab
@malcolmstill
Add elem.drop
5acd2cd
@malcolmstill
Add dropped to Elem
a32ee76
@malcolmstill
Check for overflow
dcf7b4b
@malcolmstill
Check for overflow
872af81
@malcolmstill
Fix for table_get.wast
5bba87f
@malcolmstill
Support ref arg in .asset_trap
dae6de4
@malcolmstill
run-generated.sh
6aa8eea
@malcolmstill
table.grow
4450fcf 
- Still need to set ref
@malcolmstill
table.size
d21e261
@malcolmstill
table-sub.wast
989c89a
@malcolmstill
table.fill
ae43dba
@malcolmstill
Declarative element should also be dropped at instantiation time
eaa6482
@malcolmstill
table.grow fixes
442a4b6
@malcolmstill
table_grow.json
a4e30b8
@malcolmstill
Working bulk.wast
7018b44
@malcolmstill
unreached-valid.wast + fix popOperandExpecting
c67e391 
- See WebAssembly/spec#1375
@malcolmstill malcolmstill changed the title Update Webassembly/testsuite Webassembly 2.0 support: part 1 Sep 24, 2022
@malcolmstill malcolmstill merged commit 7c9ea5a into master Sep 24, 2022
@malcolmstill malcolmstill deleted the malcolm/testsuite-update branch September 24, 2022 14:14
@malcolmstill malcolmstill mentioned this pull request Sep 24, 2022
Open
2 tasks
@malcolmstill
Copy link
Owner Author

Note: 7c9ea5a (this PR) currently is 30% slower for fib(39) than 20b456d (the commit preceding this PR).

The WebAssembly 2.0 features should not have much effect on fib...I wonder if the slow down is due to poorer code generation (maybe from the large misc handler?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@malcolmstill