fix a few unsigned/signed readI/ULEB mismatches #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a few mismatches where readULEB was being called with signed types. I fixed those and collapsed the readILEB/readULEB into one readLEB function that just uses the signedness of the native type to determine which underlying function to use.
|
Thanks @marler8997! Was this just something you noticed in the code, or was this causing some issue during parsing (and if so under what circumstances)? |
|
It was just something I noticed. I was referencing your code for one of my projects and ended up having a mismatch that actually did result in an issue. I think the only mismatches you actually had here were for valtype and reftype which only use up to 8 bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a few mismatches where readULEB was being called with signed types. I fixed those and collapsed the readILEB/readULEB into one readLEB function that just uses the signedness of the native type to determine which underlying function to use.