Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CustomDefinitionGenerator in OrcV2 #315

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Support CustomDefinitionGenerator in OrcV2 #315

wants to merge 7 commits into from

Conversation

vchuravy
Copy link
Collaborator

@vchuravy vchuravy commented Jun 9, 2022 •
edited
Loading

  • Make LLVMSymbol a subtype of AbstractString so that we can pass it directly to Libdl.dlsym
  • Add CustomDefinitionGenerator
  • Add a DynamicLibDefintionGenerator

TODO:

  • Test
  • ?Async
  • Resource cleanup

The last two will necessitate a change to LLVMExtra

@vchuravy vchuravy marked this pull request as ready for review May 15, 2023 19:07
@vchuravy vchuravy requested a review from maleadt May 15, 2023 20:32
maleadt
maleadt reviewed May 17, 2023
View reviewed changes
src/orcv2.jl Outdated Show resolved Hide resolved
vchuravy
vchuravy commented May 17, 2023
View reviewed changes
src/orcv2.jl Outdated Show resolved Hide resolved
@maleadt maleadt marked this pull request as draft September 29, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchuravy @maleadt