Revert "allow join_many: with (#1950)" (#1951)

This reverts commit 9f3b0db.

packages/malloy/src/lang/malloy-to-ast.ts

@@ -498,6 +498,12 @@ export class MalloyToAST
               'join_many: requires ON expression'
             );
           }
+        } else if (join instanceof ast.KeyJoin) {
+          this.contextError(
+            pcx,
+            'foreign-key-in-join-many',
+            'Foreign key join not legal in join_many:'
+          );
         }
       }
     }

packages/malloy/src/lang/parse-log.ts

@@ -325,6 +325,7 @@ type MessageParameterTypes = {
   'failed-to-parse-time-literal': string;
   'table-function': string;
   'missing-on-in-join-many': string;
+  'foreign-key-in-join-many': string;
   'join-statement-in-view': string;
   'unknown-matrix-operation': string;
   'declare': string;

packages/malloy/src/lang/test/source.spec.ts

@@ -178,6 +178,11 @@ describe('source:', () => {
           'source: nab is a extend { join_many: b on astr = b.astr }'
         ).toTranslate();
       });
+      test('many with', () => {
+        expect(
+          model`source: nab is a extend { ${'join_many: b with astr'} }`
+        ).toLog(errorMessage('Foreign key join not legal in join_many:'));
+      });
       test('many is on', () => {
         expect(
           'source: y is a extend { join_many: x is b on astr = x.astr }'
@@ -231,13 +236,6 @@ describe('source:', () => {
           }
         `).toTranslate();
       });
-      test('join-many: with is ok', () => {
-        expect(`
-          source: awithmany is a extend {
-            join_many: manyb is a with astr
-          }
-        `).toTranslate();
-      });
     });
     test('primary_key', () => {
       expect('source: c is a extend { primary_key: ai }').toTranslate();