pg arrays almost

malloydata · Nov 29, 2024 · 27feb85 · 27feb85
1 parent 26d1b29
commit 27feb85
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/malloy/src/dialect/postgres/postgres.ts b/packages/malloy/src/dialect/postgres/postgres.ts
@@ -457,8 +457,7 @@ export class PostgresDialect extends PostgresBase {
   }
 
   sqlLiteralArray(lit: ArrayLiteralNode): string {
-    // mtoy todo real quoting of values ... strings with quotes will break thi
     const array = lit.kids.values.map(val => val.sql);
-    return `'${JSON.stringify(array)}'::jsonb`;
+    return `ARRAY[${array.join(',')}]`;
   }
 }
diff --git a/test/src/databases/all/compound-atomic.spec.ts b/test/src/databases/all/compound-atomic.spec.ts
@@ -125,7 +125,7 @@ describe.each(runtimes.runtimeList)(
         const nameOfArrayLenFunction = {
           'duckdb': 'LEN',
           'standardsql': 'ARRAY_LENGTH',
-          'postgres': 'JSONB_ARRAY_LENGTH',
+          'postgres': 'CARDINALITY',
           'presto': 'CARDINALITY',
           'trino': 'CARDINALITY',
           'mysql': 'JSON_LENGTH',