postmess

packages/malloy/src/dialect/pg_impl.ts

@@ -99,11 +99,10 @@ export abstract class PostgresBase extends Dialect {
   }
 
   sqlLiteralRecord(_lit: RecordLiteralNode): string {
-    throw new Error('Cannot create a record literal for postgres');
+    throw new Error('Cannot create a record literal for postgres base dialect');
   }
 
-  sqlLiteralArray(lit: ArrayLiteralNode): string {
-    const array = lit.kids.values.map(val => val.sql);
-    return '{' + array.join(',') + '}';
+  sqlLiteralArray(_lit: ArrayLiteralNode): string {
+    throw new Error('Cannot create array literal for postgres base dialect');
   }
 }

packages/malloy/src/dialect/postgres/postgres.ts

@@ -32,6 +32,8 @@ import {
   TypecastExpr,
   MeasureTimeExpr,
   LeafAtomicTypeDef,
+  RecordLiteralNode,
+  ArrayLiteralNode,
 } from '../../model/malloy_types';
 import {
   DialectFunctionOverloadDef,
@@ -445,4 +447,18 @@ export class PostgresDialect extends PostgresBase {
     // Square Brackets:      INT64[]
     return sqlType.match(/^[A-Za-z\s(),[\]0-9]*$/) !== null;
   }
+
+  sqlLiteralRecord(lit: RecordLiteralNode): string {
+    const props: string[] = [];
+    for (const [kName, kVal] of Object.entries(lit.kids)) {
+      props.push(`"${kName}": ${kVal.sql}`);
+    }
+    return `{${props.join(',')}}::jsonb`;
+  }
+
+  sqlLiteralArray(lit: ArrayLiteralNode): string {
+    // mtoy todo real quoting of values ... strings with quotes will break thi
+    const array = lit.kids.values.map(val => val.sql);
+    return `'[${array.join(',')}]'::jsonb`;
+  }
 }

test/src/databases/all/compound-atomic.spec.ts

@@ -122,7 +122,7 @@ describe.each(runtimes.runtimeList)(
         const nameOfArrayLenFunction = {
           'duckdb': 'LEN',
           'standardsql': 'ARRAY_LENGTH',
-          'postgres': 'ARRAY_LENGTH',
+          'postgres': 'JSONB_ARRAY_LENGTH',
           'presto': 'CARDINALITY',
           'trino': 'CARDINALITY',
           'mysql': 'JSON_LENGTH',