Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mtoy-googly-moogly committed Nov 8, 2024
1 parent 97e5e83 commit fd68a5f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/malloy/src/lang/ast/field-space/static-space.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,11 @@ export class StaticSpace implements FieldSpace {
if (!(found instanceof StructSpaceFieldBase) && isJoined(definition)) {
// We have looked up a field which is a join, but not a StructSpaceField
// because it is someting like "dimension: joinedArray is arrayComputation"
// so it is a FieldDefinitionValue.
// which wasn't known to be a join when the fieldspace was constructed.
// TODO don't make one of these every time you do a lookup
found = new StructSpaceField(definition);
}
// cswenson review todo I don't know how to count the reference properly now
head.addReference({
type:
found instanceof StructSpaceFieldBase
Expand Down

0 comments on commit fd68a5f

Please sign in to comment.