New drill icon in the legacy renderer.

[srschandan]

VS Code light:

VS Code dark:

[whscullin]

I wonder if it would be good to have this externally configurable, since the action defined by drilling is configurable and won't likely be copy in the long run.

[srschandan]

I wonder if it would be good to have this externally configurable, since the action defined by drilling is configurable and won't likely be copy in the long run.

Agree. This was supposed to go into the new renderer but that the design and functionality is not finalized yet. This is more like get a better icon in there right now to make it look better.

[skokenes]

Code looks good, but this implementation causes the text in the table cells to no longer be vertically centered. Can you fix that?

[srschandan]

Code looks good, but this implementation causes the text in the table cells to no longer be vertically centered. Can you fix that?

Our cell contents are always aligned to top.

malloy/packages/malloy-render/src/html/table.ts

Line 417 in 49c4b9b

vertical-align: top;

I reduced the padding on the drill icon to make sure when there's only one line of data in the table, everything looks center aligned.

[skokenes]

It's weird, on multiline cells in VS Code extension it looks aligned with top line:

But on single line rows, it looks slightly off:

I don't think this really matters for now; we don't do solid control over the row height, font size etc in the old renderer so that will make it difficult to have it aligned properly to the first line in every situation.

This looks good to me