Cleanup IR, removing language like features #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every member in a field list is an interface with a type field.
Still some work to do, product still doesn't build, but I'm going to push the WIP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to make a protocol out of the IR, so it is time to cleanup the IR.
A bunch of stuff in the IR is there as a hangover from the day when the IR was the query language. It all needs go.
queries which have field references, those cannot be bare strings, because field references are paths, and the parser has parsed out the quoted pieces of the path name, and that parsed path needs to be an array in the IR
wildcards should all be expanded in the compiler, not in the IR
FilteredAliasedNames need to go away
.. and I think StructRefs also, but I al still thinking about that.