add experimental sql_functions to Malloy #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarkowitz
force-pushed
the
crs-lookml-compat
branch
from
1e747be to
19ffe36
Compare
amarkowitz
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Looks good @amarkowitz, thanks for taking this over! Just the two comments I left to address (the one on this review about escaping ${ and the one about the experiment error message).
|
Also looks like some tests are failing... looking. |
amarkowitz
force-pushed
the
crs-lookml-compat
branch
from
1a0425e to
04fb520
Compare
* add sql_* functions that allow for general sql text to be used
as expressions which return a specific type.
* these sql_* functions will also interpolate special ${...} lookml
syntax such as ${TABLE}, ${dimension}, etc
* add experimental Malloy flag 'sql_functions' that must be enabled
for your Malloy source to use this feature.
amarkowitz
force-pushed
the
crs-lookml-compat
branch
from
04fb520 to
1705ea6
Compare
|
LGTM, thanks for bringing this up to date and across the finish like @amarkowitz |
amarkowitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
sql_functionsfor this feature(The join stuff is going to be disabled for now because it doesn't fully work with the compiler's join finder yet. We were thinking first step would be to disable it with an error, second step would be to fix it and re-enable.)
Need to think about, for the future:
sql'MY SQL EXPRESSION'!number