Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup sql: and from_sql() #1657

Merged
merged 7 commits into from
Mar 18, 2024
Merged

cleanup sql: and from_sql() #1657

merged 7 commits into from
Mar 18, 2024

Conversation

mtoy-googly-moogly
Copy link
Collaborator

Some cleanup that should have happened when 4.0 finished was missed. Doing it now because other changes were touching this code, better to delete it than to keep it compiling for no reason.

Copy link
Contributor

@christopherswenson christopherswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. The bit about removing the sql keyword from the grammar will make it no longer highlight this way:
Screenshot 2024-03-18 at 12 17 14 PM

But instead like table here:
Screenshot 2024-03-18 at 12 17 20 PM

And it is probably preferable for them to be the same. Not sure which is more helpful highlighting, but a win for consistency, and I think the "function"-like highlighting is better than the "keyword"-like highlighting in this case. 👍

@mtoy-googly-moogly mtoy-googly-moogly merged commit aa42b9a into main Mar 18, 2024
7 checks passed
@mtoy-googly-moogly mtoy-googly-moogly deleted the m4-sql-changes-cleanup branch March 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants