Skip to content

Fix double nested schema parsing #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

whscullin
Copy link
Collaborator

@whscullin whscullin commented Apr 10, 2024

Handle the case of arrays in arrays - aa array(row(a double, b array(row(c integer, d varchar(60))))) was getting parsed with a name of aa array(row(a double, b and type of array(row(c integer, d varchar(60))))), this makes sure we stop at the first array(

Also fixes timestamps being returned as strings.

@whscullin whscullin requested a review from lloydtabb April 10, 2024 17:54
@whscullin
Copy link
Collaborator Author

Handle the case of arrays in arrays - aa array(row(a double, b array(row(c integer, d varchar(60))))) was getting parsed with a name of aa array(row(a double, b and type of array(row(c integer, d varchar(60))))), this makes sure we stop at the first array(

Also fixes timestamps being returned as strings.

@whscullin whscullin merged commit 8f4f15a into main Apr 10, 2024
@whscullin whscullin deleted the whscullin/fix-double-nesting branch April 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant