-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary compound datatype support #1991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoy-googly-moogly
changed the title
Next stage of array datatype support
Next stage of composite datatype support
Nov 7, 2024
mtoy-googly-moogly
changed the title
Next stage of composite datatype support
Next stage of compund datatype support
Nov 12, 2024
Thanks @lloydtabb for the test templates for the grouping ... test('can build rec select with data from table', async () => {
await expect(`
# test.debug
run: ${conName}.table('malloytest.state_facts') -> {
select: airport_count, val is {airport_count}
order_by: airport_count desc
limit: 10
}
`).malloyResultMatches(runtime, {
'airport_count': 1845,
'val.airport_count': 1845,
});
});
test('can build record group with data from table', async () => {
await expect(`
# test.debug
run: ${conName}.table('malloytest.state_facts') -> {
group_by: airport_count, val is {airport_count}
order_by: airport_count desc
limit: 10
}
`).malloyResultMatches(runtime, {airport_count: 1845});
});
test('can build array group with data from table', async () => {
await expect(`
# test.debug
run: ${conName}.table('malloytest.state_facts') -> {
group_by: airport_count, val is [airport_count]
order_by: airport_count desc
limit: 10
}
`).malloyResultMatches(runtime, {airport_count: 1845});
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that refactoring leads to this ... arrays and records working in more places. Using the word "compound" data for this, saving the word "composite" for cube-like sources.
The WN for this is https://github.com/malloydata/whatsnext/blob/main/wns/WN-0015-arrays-and-records/WN-0015.md but this is an MVP level first step. The MVP is based on avoiding some of the most common reasons Meta users are having to drop into SQL when working with compound data
select:
a compound computation