More cleanup of array functions #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* experiment with overdef * fix overdef() * mark bitwise_aggs as symmetric * move all the hll functiosn to ... def * make preto-only all def() * delete overdef * stop using def for hll functions * fix presto funcs * cleanup sequence()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pushed #2051 early to catch a release train so there would be an alpha available. Finishing up here.
In general, because some dialects have few or no functions supporting arrays, at this time, there will not be any further array functions in the standard library. We need a re-think of the standard library before that happens.
def()