Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for rendering line charts with boolean time series data. #2073

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

anagrd-ai
Copy link
Contributor

No description provided.

Signed-off-by: Jason Smart <jlsmart@meta.com>
Signed-off-by: Jason Smart <jlsmart@meta.com>
@anagrd-ai anagrd-ai changed the title Added render story that repros the issues with null or boolean series. Adds support for rendering line charts with boolean time series data. Jan 3, 2025
Signed-off-by: Jason Smart <jlsmart@meta.com>
@anagrd-ai anagrd-ai requested a review from whscullin January 3, 2025 17:27
@anagrd-ai
Copy link
Contributor Author

Screenshot 2025-01-03 092930

Fixes the boolean time series line chart bug. The null value bug will be fixed separately.

Copy link
Collaborator

@whscullin whscullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anagrd-ai anagrd-ai merged commit 4fb3e49 into main Jan 3, 2025
13 checks passed
@anagrd-ai anagrd-ai deleted the jlsmart-renderbug2 branch January 3, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants