Compute join on
expressions immediately, rather than after views have been translated
#2085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where views that used joins which had composite field usage in their
on
expressions would incorrectly not take that composite field into account when resolving a cube.Previously, we were storing all the joins while computing fields of a source (including views), then computing all the join
on
expressions after translating all the fields. Now we compute theon
expressions immediately after adding each join.