Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with referencing field in doubly-nested join inside a nest #2092

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

christopherswenson
Copy link
Contributor

In this kind of construction:

source: a_2 is a extend { join_one: b is b extend {
  join_one: c is b on 1 = c.ai
} with astr }

run: a_2 -> {
  nest: x is {
    group_by: ai is b.c.ai
  }
}

I was computing the wrong join usage (which is used for the composite sources feature). Specifically, it was making it out that ai is b.c.ai used joins b.c as well as c (unqualified). Then when the nest was evaluated in the outer query, it tried to figure out what c was (unqualified), and that doesn't exist.

@mtoy-googly-moogly mtoy-googly-moogly merged commit b88762b into main Jan 13, 2025
15 checks passed
@mtoy-googly-moogly mtoy-googly-moogly deleted the crs-fix-double-nested-join-in-nest-reference branch January 13, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants