Skip to content

Add performance graphs#21

Open
malomalo wants to merge 3 commits intomasterfrom
addBenchmarksToReadme
Open

Add performance graphs#21
malomalo wants to merge 3 commits intomasterfrom
addBenchmarksToReadme

Conversation

@malomalo
Copy link
Owner

No description provided.

@malomalo
Copy link
Owner Author

@PikachuEXE Can you run the reports yourself and see if you see similar results? The dirk test make rabl/oj and jbuilder/oj look realy slow 🧐; I know it was faster when I made this gem, but I forget if it was that much faster

Rakefile Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this makes me able to run the benchmark...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops yea, I was playing around with sizing of the graphs; need to add an option to analyzer somehow to set the size; will remove

@PikachuEXE
Copy link

Ruby 3.0.2

analyzer using latest commit to avoid the error

# Gemfile
gem 'analyzer', git: "https://github.com/malomalo/analyzer.git"
**performance/dirk/report.png**

report

**performance/rolftimmermans/report.png**

report (1)

Yup the results looks really different from what we have in #4

I will post benchmark result run in 2.7 later

@PikachuEXE
Copy link

Ruby 2.7.4

analyzer using latest commit to avoid the error

# Gemfile
gem 'analyzer', git: "https://github.com/malomalo/analyzer.git"
**performance/dirk/report.png**

report

**performance/rolftimmermans/report.png**

report

Looks similar to 3.0 result...?

@malomalo
Copy link
Owner Author

Interesting, I wonder why there is a big difference now? I think the dirk test is a caching test no? Need to do some investigating....

@malomalo
Copy link
Owner Author

Added to the test suite over at joshmn/json-benchmark#27 as well; hopefully it gets pulled in.

@PikachuEXE
Copy link

Maybe trying reverting the version of rabl to what's available when #4 is submitted and retry?

@PikachuEXE
Copy link

Ruby 2.7.4
rabl 0.14.0 - released in October 31, 2018, see https://rubygems.org/gems/rabl/versions

**performance/dirk/report.png**

report

**performance/rolftimmermans/report.png**

report

Looks similar to previous one

@PikachuEXE
Copy link

Ruby 2.5.3
rabl 0.14.0 - released in October 31, 2018, see https://rubygems.org/gems/rabl/versions

**performance/dirk/report.png**

report

**performance/rolftimmermans/report.png**

report

Thoughts?
Other dependencies changed? Benchmark itself changed?

@malomalo
Copy link
Owner Author

Just tried some debugging to see what was going on. Nothing has helped.

The last think I can maybe think of is json gem performance regressions or patches for security; because the biggest hit was on the dirk test which is mainly a caching test. JBuilder needs to read cache -> convert to hash -> merge -> result. Does RABL do the same thing?

We could investigate more but all gems are up to date and we are getting similar results.... I'm okay just merging this in.

@PikachuEXE
Copy link

Does RABL do the same thing?

I have no idea as I have never checked their source code.
I am good for merging this as long as there is nothing wrong in our benchmark/setup/whatever.

Just one thing: Why your graphs have no legend and mine have?

@malomalo
Copy link
Owner Author

I can have some coworkers run it and see if they get the same results I'll merge.

re: graphs I was playing around with smaller output for the README

@malomalo malomalo force-pushed the addBenchmarksToReadme branch from 87b5ec9 to 08c2ce9 Compare September 8, 2022 17:34
@malomalo malomalo force-pushed the master branch 4 times, most recently from 823411f to c9169f7 Compare May 20, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments