-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdt function does not respect variant cdt_name #284
Comments
Hi @wolfv - I am just running into this with RoboStack. Is there any easy workaround that you know of? |
Kind reminder @wolfv - just running into this again |
So, I was debugging the linked issue locally, and it looks like A simple (maybe hack-ish) fix is to update the --- a/boa/core/run_build.py
+++ b/boa/core/run_build.py
@@ -479,6 +479,9 @@ def run_build(args: argparse.Namespace) -> None:
config.zstd_compression_level = args.zstd_compression_level
cbc, config = get_config(folder, variant, args.variant_config_files, config=config)
+ if config.variant and "cdt_name" in cbc:
+ # HACK: ctd_name is a list
+ config.variant["cdt_name"] = cbc["cdt_name"][0]
if hasattr(args, "output_folder") and args.output_folder:
config.output_folder = args.output_folder This solves the issue in RoboStack/ros-humble#85 (when I build locally), but I also noticed another line in the build output:
This seems to imply that none of the variant files are used to update the config before passing it to |
Hi @anand-bala - great debugging, thanks for that! If you could Open a pull request, that would be amazing. Then @wolfv and others can review/comment. |
When you have a build using a conda_build_config that is say something like
then boa will false try to use the
cos6
version of the cdt and fail in this case since it does not exist.The text was updated successfully, but these errors were encountered: