Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert absolute import path to relative for better compatibility. #3036

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Convert absolute import path to relative for better compatibility. #3036

merged 1 commit into from
Dec 5, 2023

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Dec 5, 2023

Fix #3033 and #2994.

This was referenced Dec 5, 2023
Closed
Closed
Closed
@mbargull
Copy link
Contributor

mbargull commented Dec 5, 2023

Thanks for the quick work on this!
I didn't review the change, but can confirm that mamba=1.5.3 works with conda=23.11.0 when this patch is applied.

@JohanMabille
Copy link
Member

Awesome, thanks a lot @jezdez !

I'll tag a release when this is in.

@JohanMabille JohanMabille merged commit 640aada into mamba-org:1.x Dec 5, 2023
17 checks passed
@jezdez jezdez deleted the cli-imports branch December 5, 2023 13:53
@h-vetinari
Copy link

Thanks a lot for the quick handling!

Sidenote: The release notes have some formatting issues (broken links etc.)

@JohanMabille
Copy link
Member

@h-vetinari thanks, I've just fixed it.

mbargull added a commit to mbargull/mamba that referenced this pull request Dec 6, 2023
@mbargull
Convert absolute import path to relative for better compatibility.
687bb1c 
Follow-up to mamba-orggh-3036 to fix "mamba clean".
ref:
- mamba-org#3033 (comment)

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull mbargull mentioned this pull request Dec 6, 2023
Merged
@mbargull
Copy link
Contributor

mbargull commented Dec 6, 2023 •
edited
Loading

mamba clean has the same import_module("conda.cli" + ...) pattern, but at a separate place such that it was not covered with the fix here.
Reported in #3033 (comment) .
I mechanically copied @jezdez's fix over in gh-3040 and it seems to do the trick.

JohanMabille pushed a commit that referenced this pull request Dec 6, 2023
@mbargull
Convert absolute import path to relative for better compatibility. (#…
cf9c063 
…3040)

Follow-up to gh-3036 to fix "mamba clean".
ref:
- #3033 (comment)

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mathbunnyru mathbunnyru mentioned this pull request Dec 6, 2023
Merged
4 tasks
@mbargull mbargull mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jezdez @mbargull @JohanMabille @h-vetinari