fix: Ensure root prefix's conda-meta folder presence
#3752
Conversation
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
| fs::u8path conda_meta_path = ctx.prefix_params.target_prefix / "conda-meta"; | ||
| if (!fs::exists(conda_meta_path)) | ||
| { | ||
| fs::create_directories(conda_meta_path); |
There was a problem hiding this comment.
My understanding is that create_directories will not fail and is no-op if the path already exists, so the if doesnt seem necessary.
There was a problem hiding this comment.
conda-meta creation is more complex than what it seems (IIRC it depends on the command we're using create, update, install etc and the corresponding rules/constraints are different).
So I don't think we can just create the directory here without checking the (expected) behavior more thoroughly.
Also, IIUC the issue, this is not necessary and the corresponding fix was merged after 2.0.2 version.
So having this error is normal (as it's updating from 2.0.2).
|
Oh, I did not see #3572, and the original issue is not reproducible, so I guess we can close this PR. |
Fix #3734.