Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify update script to update matrix #29

Closed
maresb opened this issue Dec 11, 2023 · 5 comments · Fixed by #31
Closed

Modify update script to update matrix #29

maresb opened this issue Dec 11, 2023 · 5 comments · Fixed by #31

Comments

@maresb
Copy link
Collaborator

maresb commented Dec 11, 2023

Now that there is a matrix from #28, we should modify the update script so that the matrix is kept up-to-date.

CC @basnijholt

@basnijholt
Copy link
Contributor

I am on it!

Any idea why only one image is pushed though?

@maresb
Copy link
Collaborator Author

maresb commented Dec 11, 2023

I think it's because #28 didn't update the tags according to the base image, so I think the second-built image clobbered the first-built. We should fix that... 😁

@basnijholt
Copy link
Contributor

I do not understand the tagging very well.

I opened #31 which updates the image tags correctly.

@maresb
Copy link
Collaborator Author

maresb commented Dec 12, 2023

Ya, the combined workings of docker/metadata-action and docker/docker-push-action are pretty opaque.

type=sha,enable=true,prefix=git- means f"git-{short_sha}" and type=raw,value=latest means "latest", and those get referenced for the push via tags: ${{ steps.meta.outputs.tags }}.

What would you like to be the tag of the cuda image?

@basnijholt
Copy link
Contributor

OK I see!

What about #32?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants