Fix metadata for CUDA image #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
fix-metadata
branch
from
df565ef to
98d7ea3
Compare
basnijholt
changed the title
basnijholt
force-pushed
the
fix-metadata
branch
from
7563bd4 to
f6062b9
Compare
basnijholt
changed the title
basnijholt
force-pushed
the
fix-metadata
branch
from
f6062b9 to
a92439a
Compare
basnijholt
force-pushed
the
fix-metadata
branch
from
a92439a to
a5c481f
Compare
|
Thanks!!! Let's give it a try... |
|
Been testing this and the CUDA container works great! |
|
Wow, it's very refreshing to get some positive feedback on this project for once. I have been having nothing but problems, especially related to the installation of extensions. But since a month or so I think they finally fixed the biggest bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC then this might be the solution suggested in #29 (comment).
This changes the names to be based on the
BASE_IMAGE, e.g.,: