Order index in terms of row slices #1911
Draft
+111
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
force-pushed
the
experiment_with_index_ordering
branch
from
0a9d8b8 to
3d86b88
Compare
willdealtry
force-pushed
the
experiment_with_index_ordering
branch
from
3ae7b36 to
0a9d8b8
Compare
willdealtry
force-pushed
the
experiment_with_index_ordering
branch
from
0a9d8b8 to
6f4f0b0
Compare
|
Label error. Requires exactly 1 of: patch, minor, major. Found: replicated |
willdealtry
changed the title
alexowens90
reviewed
Mar 11, 2025
| #ifdef _WIN32 | ||
| return r.first ^ _byteswap_uint64(r.second); | ||
| #else | ||
| return r.first ^ __builtin_bswap64(r.second); | ||
| #endif | ||
| } | ||
| }; | ||
| };*/ |
There was a problem hiding this comment.
Can this presumably just be removed?
alexowens90
reviewed
Mar 11, 2025
| @@ -83,25 +83,25 @@ class IndexWriter { | |||
| // one will need to ensure that this holds, otherwise the assumptions in the read pipeline will be | |||
| // broken. | |||
alexowens90
reviewed
Mar 11, 2025
| bool new_col_group = !current_col_.has_value() || *current_col_ < slice.col_range.first; | ||
| util::check_arg(!current_row_.has_value() || new_col_group | ||
| bool new_row_group = !current_row_.has_value() || *current_row_ < slice.row_range.first; | ||
| util::check_arg(!current_row_.has_value() || new_row_group |
There was a problem hiding this comment.
Suggested change
| util::check_arg(!current_row_.has_value() || new_row_group | |
| util::check_arg(!current_col_.has_value() || new_row_group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering the index in terms of columns doesn't really make any sense, it would be better to order it by row slices.