Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds check for empty tensors and enhance tests for numpy slicing #2222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add bounds check for empty tensors and enhance tests for numpy slicing #2222

wants to merge 2 commits into from

Conversation

G-D-Petrov
Copy link
Collaborator

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@G-D-Petrov G-D-Petrov linked an issue Mar 7, 2025 that may be closed by this pull request
ArcticDB writes don't handle numpy slices/views correctly #2221
Open
@G-D-Petrov G-D-Petrov added the patch Small change, should increase patch version label Mar 7, 2025
@G-D-Petrov G-D-Petrov force-pushed the 2221-arcticdb-writes-dont-handle-numpy-slicesviews-correctly branch from 47e9a5e to be58a59 Compare March 10, 2025 07:42
@willdealtry willdealtry self-requested a review March 11, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdealtry willdealtry willdealtry approved these changes

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
patch Small change, should increase patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArcticDB writes don't handle numpy slices/views correctly
2 participants
@G-D-Petrov @willdealtry