Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pin for fmt in conda #2223

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Add pin for fmt in conda #2223

merged 1 commit into from
Mar 7, 2025

Conversation

G-D-Petrov
Copy link
Collaborator

@G-D-Petrov G-D-Petrov commented Mar 7, 2025

Reference Issues/PRs

What does this implement or fix?

There is a new version of fmt that is having problems linking to spdlog.
The proposed fix is to pin fmt to the previous stable version.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@G-D-Petrov G-D-Petrov added the patch Small change, should increase patch version label Mar 7, 2025
Copy link
Collaborator

@poodlewars poodlewars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - this seems unavoidable. We'll have to remember to add this to the feedstock when we next do a Conda release

@G-D-Petrov G-D-Petrov merged commit 48da603 into master Mar 7, 2025
145 of 147 checks passed
@G-D-Petrov G-D-Petrov deleted the fix_conda_build branch March 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Small change, should increase patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants