Skip to content

Fix azure test real credential issue #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix azure test real credential issue #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c403786
Fix azure test real credential issue
phoebusm Nov 13, 2025
1f19d04
Fix missing import
phoebusm Nov 13, 2025
e537a87
Fix path too long
phoebusm Nov 13, 2025
5eb40bb
Simplify prefix
phoebusm Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,24 +385,21 @@ def mock_s3_storage_with_error_simulation(mock_s3_storage_with_error_simulation_
@pytest.fixture(scope="session")
def real_s3_storage_factory() -> BaseS3StorageFixtureFactory:
return real_s3_from_environment_variables(
shared_path=False,
additional_suffix=f"{random.randint(0, 999)}_{datetime.utcnow().strftime('%Y-%m-%dT%H_%M_%S_%f')}",
shared_path=False
)


@pytest.fixture(scope="session")
def real_gcp_storage_factory() -> BaseGCPStorageFixtureFactory:
return real_gcp_from_environment_variables(
shared_path=False,
additional_suffix=f"{random.randint(0, 999)}_{datetime.utcnow().strftime('%Y-%m-%dT%H_%M_%S_%f')}",
shared_path=False
)


@pytest.fixture(scope="session")
def real_azure_storage_factory() -> AzureStorageFixtureFactory:
return real_azure_from_environment_variables(
shared_path=False,
additional_suffix=f"{random.randint(0, 999)}_{datetime.utcnow().strftime('%Y-%m-%dT%H_%M_%S_%f')}",
shared_path=False
)


Expand Down
3 changes: 2 additions & 1 deletion python/tests/util/storage_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import argparse
import re
from datetime import datetime
import ssl

from arcticdb import Arctic
from arcticc.pb2.s3_storage_pb2 import Config as S3Config
Expand Down Expand Up @@ -170,7 +171,7 @@ def find_ca_certs():
### there is no way how arcticdb 3.0 could have had the functions that we are going to implement
### and support from now on
def get_real_azure_uri(shared_path: bool = True):
container, constr, path_prefix = real_azure_credentials(shared_path)
container, constr, path_prefix, _ = real_azure_credentials(shared_path)
ca_certs_file = find_ca_certs()
uri = f"azure://Container={container};Path_prefix={path_prefix}"
assert ca_certs_file, f"CA file: {ca_certs_file} not found!"
Expand Down
Loading