Add a mechanism to silence noisy s3 simulator logs#2945
Open
G-D-Petrov wants to merge 7 commits intomasterfrom
Open
Add a mechanism to silence noisy s3 simulator logs#2945G-D-Petrov wants to merge 7 commits intomasterfrom
G-D-Petrov wants to merge 7 commits intomasterfrom
Conversation
Contributor
ArcticDB Code Review SummaryAPI and Compatibility
Memory and Safety
Correctness
Code Quality
Testing
Build and Dependencies
Security
PR Title and Description
Documentation
SummaryCommit 18b9b3a fixes the one blocking bug introduced in c46a499:
Previously fixed (still good):
Remaining non-blocking items:
|
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
5123d03 to
d338177
Compare
vasil-pashov
approved these changes
Mar 2, 2026
…ment variable parsing
vasil-pashov
reviewed
Mar 4, 2026
|
|
||
|
|
||
| def run_s3_server(port, key_file, cert_file): | ||
| verbose = strtobool("ARCTICDB_MOTO_VERBOSE") |
Collaborator
There was a problem hiding this comment.
Claude is right about this one, strtobool only converts to true/false but does not read the env. So you'd have to os.environ.get first
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
The s3 simulator generates a lot of noisy logs for all HTTP requests against it like:
In many cases, these logs are not useful and are just filling up the logs, making it harder to debug the actual problem.
This PR adds a way to disable the logs(redirecting them using
_suppress_moto_server_stdio) and disables them by default.Any other comments?
Checklist
Checklist for code changes...