Restrict aws-sdk-cpp version range in environment-dev.yml

[G-D-Petrov]

Reference Issues/PRs

What does this implement or fix?

There is an issue with STS flow in the latest aws sdk version on conda.
This PR pins the version to the latest known working version.

Any other comments?

Checklist

Checklist for code changes...

• Have you updated the relevant docstrings, documentation and copyright notice?
• Is this contribution tested against all ArcticDB's features?
• Do all exceptions introduced raise appropriate error messages?
• Are API changes highlighted in the PR description?
• Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

[claude]

The upper bound <=1.11.591 is a workaround for a broken STS flow in newer releases. Consider adding an inline comment to make this explicit and link to a tracking issue so it's clear when the pin can be removed:

Suggested change

	- aws-sdk-cpp >=1.11.405,<=1.11.591
	- aws-sdk-cpp >=1.11.405,<=1.11.591 # upper bound: STS broken in newer releases (see #<issue>)

Without a comment or linked issue, future maintainers may not know this is a temporary pin and may not revisit it when the upstream bug is fixed.

[jjerphan]

Could you document the version of aws-sdk-cpp for which would have observed this issue with STS? Is it aws-sdk-cpp==1.11.606?

[jjerphan]

Is the issue aws/aws-sdk-cpp#2920?

[claude]

ArcticDB Code Review Summary

PR: Restrict aws-sdk-cpp version range in environment-dev.yml
Scope: Single-line change in environment-dev.yml adds an upper bound and explanatory comment to the aws-sdk-cpp conda dependency.

---

API and Compatibility

• No breaking changes to public Python API
• On-disk format unchanged
• Protobuf schema unchanged
• Key types and ValueType enum unchanged
• N/A Deprecation protocol (no removed/renamed parameters)

Memory and Safety

• N/A (no C++ changes)

Correctness

• Change is narrowly scoped to conda dev environment; does not affect vcpkg or production builds

Code Quality

• Comment added explaining rationale and linking to upstream PR
• No duplicated logic

Testing

• N/A (dependency version pin; no behavioural change to ArcticDB code)

Build and Dependencies

• Upper bound <=1.11.591 pins to last known working version for STS flow
• Comment references upstream aws/aws-sdk-cpp PR for traceability
• Only environment-dev.yml (conda dev env) affected; vcpkg manifest unchanged
• WARNING: No tracking issue linked - consider opening or linking a GitHub issue so the pin can be revisited when aws-sdk-cpp releases a fix. Reviewer jjerphan has also asked about this inline.
• Label is patch - appropriate for this change

Security

• No hardcoded credentials or secrets
• N/A (no new input boundaries)

PR Title and Description

• Title is clear and concise
• Description explains the STS issue and the fix
• WARNING: No linked issue in the description - low severity for a simple version pin, but linking to a tracking issue would help make clear when the pin can be relaxed
• No API/breaking changes to call out

Documentation

• N/A (no public API or docstring changes)

---

Summary: Minimal, low-risk change. The main open question is whether there is a GitHub issue tracking when the upper bound on aws-sdk-cpp can be removed - both the prior inline review and jjerphan comments have raised this. No blocking issues found.