Skip to content

Commit

Permalink
Update src/array.cpp
Browse files Browse the repository at this point in the history
Co-authored-by: Alexis Placet <alexis.placet@gmail.com>
  • Loading branch information
JohanMabille and Alex-PLACET authored Jan 31, 2025
1 parent 4f4b65a commit 7036bde
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/array.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,9 @@ namespace sparrow
return get_arrow_proxy().name();
}

void array::set_name(std::string_view name)
void array::set_name(std::optional<std::string_view> name)

Check failure on line 55 in src/array.cpp

View workflow job for this annotation

GitHub Actions / build

src/array.cpp:55:17 [clang-diagnostic-error]

out-of-line definition of 'set_name' does not match any declaration in 'sparrow::array'
{
arrow_proxy& proxy = detail::array_access::get_arrow_proxy(*this);
proxy.set_name(name);
get_arrow_proxy().set_name(name);
}

bool array::empty() const
Expand Down

0 comments on commit 7036bde

Please sign in to comment.