Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display unsubmitted assignments on the manaba home page #561

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

yudukikun5120
Copy link
Collaborator

No description provided.

.then((DOM) => asgPageTable(DOM))
.then((table) => table && getAsgsFromTable(table))

const renderUnsubmittedAsgsOnHome = (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function renderUnsubmittedAsgsOnHome has 46 lines of code (exceeds 25 allowed). Consider refactoring.

@yudukikun5120
Copy link
Collaborator Author

@mkobayashime I'd rather get this PR ready for review after #505 and #558 are resolved.

@yudukikun5120 yudukikun5120 changed the title feat: Display unsubmitted assignments on the manaba home page feat: display unsubmitted assignments on the manaba home page Dec 21, 2022
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023

Code Climate has analyzed commit 1c7cb4d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant