Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2039420a3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| hex.removeFirst() | ||
| } | ||
| guard hex.count == 6 else { return nil } | ||
| guard hex.count == 6 || hex.count == 8 else { return nil } |
There was a problem hiding this comment.
Blend alpha colors before deriving text contrast
Allowing 8-digit hex values here introduces translucent chrome colors, but text/icon contrast is still computed from raw RGB in effectiveTextColor/isBonsplitLightColor without considering alpha compositing against the fallback background. With inputs like #00000000 (or any low-alpha dark color) on a light window, the code picks white foreground text even though the rendered background is effectively light, making tab labels hard to read.
Useful? React with 👍 / 👎.
Summary
#RRGGBBAAinBonsplitConfiguration.Appearance.ChromeColors.backgroundHex#RRGGBBbehavior unchangedContext