Skip to content

Support alpha in chrome background hex#6

Open
lawrencecchen wants to merge 3 commits intomainfrom
issue-263-chrome-alpha-hex
Open

Support alpha in chrome background hex#6
lawrencecchen wants to merge 3 commits intomainfrom
issue-263-chrome-alpha-hex

Conversation

@lawrencecchen
Copy link

@lawrencecchen lawrencecchen commented Feb 21, 2026

Summary

  • accept #RRGGBBAA in BonsplitConfiguration.Appearance.ChromeColors.backgroundHex
  • keep existing #RRGGBB behavior unchanged
  • add a regression test that verifies parsed RGBA components for pane background

Context

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2039420a3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

hex.removeFirst()
}
guard hex.count == 6 else { return nil }
guard hex.count == 6 || hex.count == 8 else { return nil }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Blend alpha colors before deriving text contrast

Allowing 8-digit hex values here introduces translucent chrome colors, but text/icon contrast is still computed from raw RGB in effectiveTextColor/isBonsplitLightColor without considering alpha compositing against the fallback background. With inputs like #00000000 (or any low-alpha dark color) on a light window, the code picks white foreground text even though the rendered background is effectively light, making tab labels hard to read.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant