Add the Time Travel Debugging CLI package #1092
Conversation
d35ha
added
🆕 package
d35ha
force-pushed
the
time-travel-debugging-cli
branch
from
ab1ee9b
to
78f6886
Compare
d35ha
force-pushed
the
time-travel-debugging-cli
branch
2 times, most recently
from
b17636f
to
b77acb1
Compare
|
Installs correctly and works well! I want to make sure @Ana06 checks it over to agree that it will work with this method rather than needing to use If this URL format works for future updates, then I think it should be good to go. :) |
| # Attempt to remove temporary directory | ||
| Remove-Item $tempDownloadDir -Recurse -Force -ea 0 | ||
|
|
||
| VM-Install-Shortcut -toolName $toolName -category $category -executablePath "$toolName.exe" -consoleApp $true -runAsAdmin |
There was a problem hiding this comment.
This tool doesn't have an icon, it's using the default executable icon.
d35ha
force-pushed
the
time-travel-debugging-cli
branch
4 times, most recently
from
ca09758
to
db84bb5
Compare
| $bundleUrl = "https://windbg.download.prss.microsoft.com/dbazure/prod/1-11-319-0/TTD.msixbundle" | ||
| $bundleSha256 = "f7b80731c3a6994b3763c4100073b101965327d6556fa4bfb553d70ce49be366" | ||
| $bundlePath = Join-Path ${Env:TEMP} "$($toolName)_1-11-319-0.msixbundle" | ||
| Get-ChocolateyWebFile -PackageName $toolName -FileFullPath $bundlePath -Url $bundleUrl -Checksum $bundleSha256 -ChecksumType "sha256" |
There was a problem hiding this comment.
[nitpick] I would prefer to use the $packageArgs = @{} syntax for consistency with other packages
There was a problem hiding this comment.
In #1058 I have done it like below :
$packageArgs = @{
packageName = ${Env:ChocolateyPackageName}
url = $bundleUrl
checksum = $bundleSha256
checksumType = "sha256"
fileFullPath = Join-Path ${Env:TEMP} "$toolName.msixbundle"
}
Get-ChocolateyWebFile @packageArgs
Add-AppxPackage -Path $packageArgs.fileFullPath
| # From https://aka.ms/ttd/download | ||
| $bundleUrl = "https://windbg.download.prss.microsoft.com/dbazure/prod/1-11-319-0/TTD.msixbundle" | ||
| $bundleSha256 = "f7b80731c3a6994b3763c4100073b101965327d6556fa4bfb553d70ce49be366" | ||
| $bundlePath = Join-Path ${Env:TEMP} "$($toolName)_1-11-319-0.msixbundle" |
There was a problem hiding this comment.
I don't think it's necessary to specify the version here. Join-Path ${Env:TEMP} "$toolName.msixbundle" is enough.
There was a problem hiding this comment.
I agree, it will need less changes when updating
d35ha
force-pushed
the
time-travel-debugging-cli
branch
from
db84bb5
to
fc6f73a
Compare
Closes #965.