Skip to content

feat: allow-none-key-name#693

Open
Yujonpradhananga wants to merge 1 commit intomangowm:mainfrom
Yujonpradhananga:feat/allow-none-key-name
Open

feat: allow-none-key-name#693
Yujonpradhananga wants to merge 1 commit intomangowm:mainfrom
Yujonpradhananga:feat/allow-none-key-name

Conversation

@Yujonpradhananga
Copy link
Contributor

Summary:

This PR implements true modifier-only keybindings (e.g., bindr=SUPER,none,toggleovervie).
It allows an action to fire when a modifier key is released, but only if no other key was pressed during the hold.
Introduces mod_key_used and prev_mods to track state. If you press SUPER+R to reload, the solo SUPER release won't accidentally trigger a "none" binding.
The config parser now recognizes the "none" key. It also includes safety logic that automatically forces release mode (bindr) for these bindings and issues a warning if the user accidentally uses the standard

Closes #689

@DreamMaoMao DreamMaoMao force-pushed the main branch 2 times, most recently from dc016eb to 6b2d694 Compare February 22, 2026 03:52
@demperor-music
Copy link

demperor-music commented Feb 22, 2026

The none keybinds seem to trigger if trying to activate a shortcut involving an additional modifier.
Example: Super,none,toggleoverview activates when pressing SUPER+SHIFT if you start the chord by pressing SUPER rather than SHIFT

@Yujonpradhananga
Copy link
Contributor Author

Oh my bad, I fixed the bug in f0fe874, now it should work as intended @demperor-music

@mariokhz
Copy link

thank you!!!

@mariokhz
Copy link

if you are using bind=SUPER,none, doing SUPER+CLICK to move a window will activate the bind once SUPER is released

@Yujonpradhananga
Copy link
Contributor Author

Yujonpradhananga commented Feb 24, 2026

Oh I didnt think about the mouse click behaviour at all as I have never used it , but I've added the fix at 6236adb
I've squashed the commits too for better readability
could you try it out @mariokhz @demperor-music

Fixed none keybind trigger involving an additional modifier bug

Fixed mouse click behaviour bug
@Yujonpradhananga Yujonpradhananga changed the title feat/allow-none-key-name feat: allow-none-key-name Feb 24, 2026
@Yujonpradhananga
Copy link
Contributor Author

@DreamMaoMao Can this be merged Maomao?

@demperor-music
Copy link

The fix works just fine on my machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow "none" as key name.

3 participants