Open
Conversation
dc016eb to
6b2d694
Compare
|
The |
Contributor
Author
|
Oh my bad, I fixed the bug in f0fe874, now it should work as intended @demperor-music |
|
thank you!!! |
|
if you are using bind=SUPER,none, doing SUPER+CLICK to move a window will activate the bind once SUPER is released |
Contributor
Author
|
Oh I didnt think about the mouse click behaviour at all as I have never used it , but I've added the fix at 6236adb |
Fixed none keybind trigger involving an additional modifier bug Fixed mouse click behaviour bug
b880f42 to
6236adb
Compare
Contributor
Author
|
@DreamMaoMao Can this be merged Maomao? |
|
The fix works just fine on my machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR implements true modifier-only keybindings (e.g., bindr=SUPER,none,toggleovervie).
It allows an action to fire when a modifier key is released, but only if no other key was pressed during the hold.
Introduces mod_key_used and prev_mods to track state. If you press SUPER+R to reload, the solo SUPER release won't accidentally trigger a "none" binding.
The config parser now recognizes the "none" key. It also includes safety logic that automatically forces release mode (bindr) for these bindings and issues a warning if the user accidentally uses the standard
Closes #689