Skip to content

Remove powerDown() from write command. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove powerDown() from write command. #27

wants to merge 1 commit into from

Conversation

sourceperl
Copy link

Hi Maniacbug,

Thanks for your great job ! It's very useful for me.

I have some compatibility problem with Olimex MOD-24LR board and RF24 lib so i have to change the code.

Commit detail:

Remove powerDown() from write command. Now, we can use Power On/Off from user application. Necessary because XTAL startup time is not the same for every NRF board.PowerUp can take more than 1 ms (see 6.1.7 "Tpd2stdby" in nRF24L01+ product specification). For my test on Olimex MOD-24LR module delayMicroseconds(150) after PowerUp on startWrite is too short and write don't work. It's difficult to have an optimized value for every case. So, it's probably better to do this on user app.

Have a nice day,
Loic Lefebvre

Remove powerDown() from write command. Now, we can use Power On/Off from user application. Necessary because XTAL startup time is not the same for every NRF board.PowerUp can take more than 1 ms (see 6.1.7 "Tpd2stdby" in nRF24L01+ product specification). For my test on Olimex MOD-24LR module delayMicroseconds(150) after PowerUp on startWrite is too short and write don't work. It's difficult to have an optimized value for every case. So, it's probably better to do this on user app.
@gcopeland
Copy link
Contributor

Look at my fork. It has this optimization as will as new features.
On Sep 3, 2013 11:16 AM, "l.lefebvre" notifications@github.com wrote:

Remove powerDown() from write command. Now, we can use Power On/Off from
user application. Necessary because XTAL startup time is not the same for
every NRF board.PowerUp can take more than 1 ms (see 6.1.7 "Tpd2stdby" in
nRF24L01+ product specification). For my test on Olimex MOD-24LR module
delayMicroseconds(150) after PowerUp on startWrite is too short and write
don't work. It's difficult to have an optimized value for every case. So,

it's probably better to do this on user app.

You can merge this Pull Request by running

git pull https://github.com/sourceperl/RF24 master

Or view, comment on, or merge it at:

#27
Commit Summary

  • Remove powerDown() from write command.

File Changes

Patch Links:

@sourceperl
Copy link
Author

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !

@gcopeland
Copy link
Contributor

Glad to hear it. Thanks for the feedback.
On Sep 4, 2013 3:32 PM, "l.lefebvre" notifications@github.com wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-23821601
.

@stanleyseow
Copy link

Greg,

U hv the best "fork" in town...

Send from iPhone4 ;-)

On 5 Sep 2013, at 08:47 AM, gcopeland notifications@github.com wrote:

Glad to hear it. Thanks for the feedback.
On Sep 4, 2013 3:32 PM, "l.lefebvre" notifications@github.com wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-23821601
.


Reply to this email directly or view it on GitHub.

@gcopeland
Copy link
Contributor

Thanks man.

Can't wait until I have time to focus on my hobbies again.
On Sep 4, 2013 8:32 PM, "Stanley Seow" notifications@github.com wrote:

Greg,

U hv the best "fork" in town...

Send from iPhone4 ;-)

On 5 Sep 2013, at 08:47 AM, gcopeland notifications@github.com wrote:

Glad to hear it. Thanks for the feedback.
On Sep 4, 2013 3:32 PM, "l.lefebvre" notifications@github.com wrote:

Hi gcopeland,

MOD-24LR board work fine with your fork. Thanks a lot !


Reply to this email directly or view it on GitHub<
https://github.com/maniacbug/RF24/pull/27#issuecomment-23821601>
.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-23838491
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants